New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Add optional environment variables #187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
============================================
+ Coverage 58.37% 58.45% +0.07%
- Complexity 1270 1272 +2
============================================
Files 158 158
Lines 8428 8437 +9
Branches 782 782
============================================
+ Hits 4920 4932 +12
+ Misses 3255 3254 -1
+ Partials 253 251 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
How about unify |
I think we can define |
@@ -20,10 +20,8 @@ | |||
set -o pipefail | |||
set -o nounset # exit the script if you try to use an uninitialised variable | |||
set -o errexit # exit the script if any statement returns a non-true return value | |||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unify style. In these scripts, rewrite set -e
to set -o errexit
.
set -e
same as set -o errexit
: https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html
Done. Would you mind take a look when you have some time? @colinmjj |
LGTM, +1, thanks for the contribution, @izchen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, @izchen thanks
What changes were proposed in this pull request?
Added six optional environment variables:
Why are the changes needed?
Simplify service deployment
Does this PR introduce any user-facing change?
Added six optional environment variables.
With the default environment variables, the behavior is the same as before this PR.
How was this patch tested?
local test