[Log-Improvement] Log the newly registered app id #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmjj
reviewed
Aug 31, 2022
coordinator/src/main/java/org/apache/uniffle/coordinator/ApplicationManager.java
Outdated
Show resolved
Hide resolved
jerqi
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[Log-Improvement] Log the newly registered app id
Why are the changes needed?
I hope from the coordinator log, I could directly find the newly registered app and manually monitor its state.
Besides, the appId in uniffle is different from the Yarn appId, it's with the timestamp. So it's better to add the spilt KEY for debugging.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not necessary.