Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][IMPROVEMENT] Return index-file size of n*SEGMENT_SIZE in HDFS reading #204

Merged
merged 4 commits into from Sep 9, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Sep 7, 2022

What changes were proposed in this pull request?

Return index-file size of n*SEGMENT_SIZE in HDFS reading

Why are the changes needed?

It should keep consistent with the logic of returning the complete index data in localfile reader that data size is always n*SEGMENT_SIZE.

Does this PR introduce any user-facing change?

No

How was this patch tested?

@zuston zuston marked this pull request as draft September 7, 2022 09:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #204 (1cfe418) into master (9b83f66) will increase coverage by 0.03%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     59.02%   59.06%   +0.03%     
- Complexity     1326     1327       +1     
============================================
  Files           160      160              
  Lines          8699     8708       +9     
  Branches        815      817       +2     
============================================
+ Hits           5135     5143       +8     
+ Misses         3301     3300       -1     
- Partials        263      265       +2     
Impacted Files Coverage Δ
.../storage/handler/impl/HdfsShuffleWriteHandler.java 85.07% <ø> (ø)
...orage/handler/impl/LocalFileServerReadHandler.java 77.96% <50.00%> (-2.40%) ⬇️
...e/storage/handler/impl/HdfsShuffleReadHandler.java 57.14% <87.50%> (+6.12%) ⬆️
.../java/org/apache/uniffle/common/util/RssUtils.java 69.32% <100.00%> (-0.80%) ⬇️
.../apache/uniffle/common/exception/RssException.java 100.00% <0.00%> (+50.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston
Copy link
Member Author

zuston commented Sep 8, 2022

PTAL @jerqi . If OK, I will add some UTs.

@jerqi
Copy link
Contributor

jerqi commented Sep 8, 2022

PTAL @jerqi . If OK, I will add some UTs.

You can go ahead.

@zuston zuston marked this pull request as ready for review September 9, 2022 03:33
@zuston zuston closed this Sep 9, 2022
@zuston zuston reopened this Sep 9, 2022
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants