Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add more metrics about local storage info #205

Merged
merged 3 commits into from Sep 9, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Sep 8, 2022

What changes were proposed in this pull request?

Introduce more local storage infos' metrics.

Why are the changes needed?

In current codebase, there is no such local storage space info metrics. After this PR, we could monitor the disk utilization easily.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UTs.

@zuston
Copy link
Member Author

zuston commented Sep 8, 2022

If you have time, PTAL @jerqi

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #205 (0d09620) into master (78a0371) will decrease coverage by 0.58%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
- Coverage     58.89%   58.30%   -0.59%     
- Complexity     1309     1348      +39     
============================================
  Files           160      160              
  Lines          8615     9069     +454     
  Branches        801      914     +113     
============================================
+ Hits           5074     5288     +214     
- Misses         3282     3521     +239     
- Partials        259      260       +1     
Impacted Files Coverage Δ
...org/apache/uniffle/server/LocalStorageChecker.java 70.19% <90.90%> (+2.45%) ⬆️
...in/java/org/apache/uniffle/server/HealthCheck.java 61.36% <100.00%> (+1.83%) ⬆️
...rg/apache/uniffle/server/ShuffleServerMetrics.java 96.11% <100.00%> (+0.24%) ⬆️
...pache/uniffle/server/ShuffleServerGrpcService.java 1.24% <0.00%> (+0.26%) ⬆️
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 26.20% <0.00%> (+0.83%) ⬆️
...che/uniffle/server/storage/HdfsStorageManager.java 92.00% <0.00%> (+2.00%) ⬆️
.../java/org/apache/uniffle/common/util/RssUtils.java 73.51% <0.00%> (+7.31%) ⬆️
.../org/apache/uniffle/server/ShuffleTaskManager.java 75.00% <0.00%> (+10.71%) ⬆️
...rg/apache/uniffle/server/ShuffleDataReadEvent.java 75.00% <0.00%> (+75.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston zuston closed this Sep 9, 2022
@zuston zuston reopened this Sep 9, 2022
@zuston zuston closed this Sep 9, 2022
@zuston zuston reopened this Sep 9, 2022
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@jerqi jerqi merged commit 517e5b1 into apache:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants