-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-48][FEATURE][FOLLOW UP] Add controller component #214
Conversation
@czy006 @zuston @thousandhu Could you help me review this patch? |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
============================================
+ Coverage 58.48% 59.12% +0.63%
- Complexity 1277 1326 +49
============================================
Files 158 160 +2
Lines 8463 8725 +262
Branches 785 816 +31
============================================
+ Hits 4950 5159 +209
- Misses 3259 3301 +42
- Partials 254 265 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
08a002c
to
30ecd9e
Compare
deploy/kubernetes/operator/pkg/controller/constants/constants.go
Outdated
Show resolved
Hide resolved
30ecd9e
to
126f893
Compare
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok? |
126f893
to
a3a3cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wangao1236 @thousandhu
What changes were proposed in this pull request?
For issue #48
I add some codes about controller module, and I'll add more unit tests in next PR.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?