New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notice and DISCLAMER file #215
Conversation
NOTICE
Outdated
Copyright 2014 and onwards The Apache Software Foundation. | ||
|
||
Apache Hadoop | ||
Copyright 2006 and onwards The Apache Software Foundation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage 59.13% 59.13%
Complexity 1327 1327
=========================================
Files 160 160
Lines 8727 8727
Branches 817 817
=========================================
Hits 5161 5161
Misses 3301 3301
Partials 265 265 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can you please check the contents of NOTICE from more projects, and the requirements from ASF? |
For source release, it seems that we do not need extra contents.
|
So maybe we don't need to list spark and hadoop license? |
Yes, I have removed them in NOTICE. |
NOTICE
Outdated
The Apache Software Foundation (https://www.apache.org/). | ||
|
||
The initial codebase was donated to the ASF by Tencent, copyright 2020-2022. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
What changes were proposed in this pull request?
Add a notice file.
References:
https://github.com/apache/inlong/blob/master/NOTICE
https://github.com/apache/spark/blob/master/NOTICE
https://infra.apache.org/licensing-howto.html
Why are the changes needed?
For apache release.
#207
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.