Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notice and DISCLAMER file #215

Merged
merged 2 commits into from Sep 14, 2022
Merged

Add Notice and DISCLAMER file #215

merged 2 commits into from Sep 14, 2022

Conversation

frankliee
Copy link
Contributor

@frankliee frankliee commented Sep 13, 2022

What changes were proposed in this pull request?

Add a notice file.

References:
https://github.com/apache/inlong/blob/master/NOTICE
https://github.com/apache/spark/blob/master/NOTICE
https://infra.apache.org/licensing-howto.html

Why are the changes needed?

For apache release.
#207

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

NOTICE Outdated
Copyright 2014 and onwards The Apache Software Foundation.

Apache Hadoop
Copyright 2006 and onwards The Apache Software Foundation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #215 (f43364a) into master (3d4de8c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #215   +/-   ##
=========================================
  Coverage     59.13%   59.13%           
  Complexity     1327     1327           
=========================================
  Files           160      160           
  Lines          8727     8727           
  Branches        817      817           
=========================================
  Hits           5161     5161           
  Misses         3301     3301           
  Partials        265      265           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerryshao
Copy link
Contributor

Can you please check the contents of NOTICE from more projects, and the requirements from ASF?

@frankliee
Copy link
Contributor Author

Can you please check the contents of NOTICE from more projects, and the requirements from ASF?

For source release, it seems that we do not need extra contents.

For any bundled dependency, consider whether LICENSE and/or NOTICE need to be modified. Do not modify LICENSE or NOTICE for non-bundled dependencies.

https://infra.apache.org/licensing-howto.html

@jerryshao
Copy link
Contributor

So maybe we don't need to list spark and hadoop license?

@frankliee
Copy link
Contributor Author

So maybe we don't need to list spark and hadoop license?

Yes, I have removed them in NOTICE.

NOTICE Outdated Show resolved Hide resolved
NOTICE Show resolved Hide resolved
NOTICE Outdated
The Apache Software Foundation (https://www.apache.org/).

The initial codebase was donated to the ASF by Tencent, copyright 2020-2022.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jerryshao jerryshao changed the title Add Notice Add Notice and DISCLAMER file Sep 14, 2022
@jerryshao jerryshao merged commit dcdf8ae into apache:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants