Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect log format strings #220

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix incorrect log format strings #220

merged 1 commit into from
Sep 15, 2022

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Fix incorrect log format strings.

Why are the changes needed?

SLF4J use {} as placeholder in format strings.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen
Copy link
Contributor Author

Cc @jerqi.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #220 (3e461ae) into master (dcdf8ae) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #220   +/-   ##
=========================================
  Coverage     59.13%   59.13%           
  Complexity     1327     1327           
=========================================
  Files           160      160           
  Lines          8727     8727           
  Branches        817      817           
=========================================
  Hits           5161     5161           
  Misses         3301     3301           
  Partials        265      265           
Impacted Files Coverage Δ
...e/coordinator/AppBalanceSelectStorageStrategy.java 72.34% <0.00%> (ø)
...nator/LowestIOSampleCostSelectStorageStrategy.java 73.14% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge master and branch 0.6

@jerqi jerqi merged commit 20aa41d into apache:master Sep 15, 2022
jerqi pushed a commit that referenced this pull request Sep 15, 2022
### What changes were proposed in this pull request?

Fix incorrect log format strings.

### Why are the changes needed?

SLF4J use `{}` as placeholder in format strings.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.
@kaijchen kaijchen deleted the log-fix branch September 15, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants