Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics about requiring read memory #231

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Sep 20, 2022

What changes were proposed in this pull request?

Add more metrics about requiring read memory

  1. total_require_read_memory_num
  2. total_require_read_memory_retry_num
  3. total_require_read_memory_failed_num

Why are the changes needed?

These metrics can be as the indicator of high-watermark pressure.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need.

@zuston
Copy link
Member Author

zuston commented Sep 20, 2022

PTAL @jerqi

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@jerqi jerqi merged commit 42e2605 into apache:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants