Set the default disk capacity to the total space #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem occurred in our internal uniffle cluster. PTAL @jerqi |
|
Should we modify the document at the same time? |
Yes. If this direction is OK, I will go ahead to add more tests and doc. |
|
It's ok for me. |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
============================================
- Coverage 59.16% 59.14% -0.03%
Complexity 1332 1332
============================================
Files 160 160
Lines 8738 8740 +2
Branches 820 821 +1
============================================
- Hits 5170 5169 -1
- Misses 3303 3305 +2
- Partials 265 266 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Sep 24, 2022
|
Thanks @jerqi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the default disk capacity to the total space
Why are the changes needed?
When shuffle-servers are colocated with NodeManagers, the disk capacity is hard to set. Because when it's equal with the total space, it will cause the most shuffle-servers startup fail due to free-space checking. If not, it will waste some disk resources.
And the default disk capacity is 1TB, it's not out-of-box value. So this PR is to set the default value of 'rss.server.disk.capacity' to the disk total space.
Does this PR introduce any user-facing change?
No
How was this patch tested?