Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-196] Fix flaky test about kerberos #250

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

zuston
Copy link
Member

@zuston zuston commented Sep 28, 2022

What changes were proposed in this pull request?

Fix flaky test about kerberos #196

Why are the changes needed?

Fix flaky test

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #250 (73fb133) into master (54ddca6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     59.29%   59.25%   -0.04%     
+ Complexity     1346     1345       -1     
============================================
  Files           162      162              
  Lines          8789     8789              
  Branches        828      828              
============================================
- Hits           5211     5208       -3     
- Misses         3311     3313       +2     
- Partials        267      268       +1     
Impacted Files Coverage Δ
...rg/apache/uniffle/storage/common/LocalStorage.java 42.75% <0.00%> (-2.07%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/build.yml Outdated Show resolved Hide resolved
@jerqi jerqi changed the title Fix flaky test about kerberos [ISSUE-196] Fix flaky test about kerberos Sep 28, 2022
@jerqi jerqi linked an issue Sep 28, 2022 that may be closed by this pull request
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@jerqi jerqi merged commit 0fe0a90 into apache:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test ShuffleFlushManagerOnKerberizedHdfsTest
3 participants