[ISSUE-244] Fix flaky test of CoordinatorGrpcTest.rpcMetricsTest #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @jerqi |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 59.18% 59.18%
- Complexity 1343 1344 +1
=========================================
Files 163 163
Lines 8837 8837
Branches 835 835
=========================================
Hits 5230 5230
Misses 3339 3339
Partials 268 268 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
jerqi
pushed a commit
that referenced
this pull request
Oct 12, 2022
### What changes were proposed in this pull request? [ISSUE-244] Fix flaky test of CoordinatorGrpcTest.rpcMetricsTest ### Why are the changes needed? 1. The gauge metric of `HEARTBEAT_METHOD` is hard to meansure due to async sending at background. So remove it 2. The gauge metric of `GET_SHUFFLE_ASSIGNMENTS_METHOD` may be not called `descCounter` when rpc finished, so remove it ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Dont need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[ISSUE-244] Fix flaky test of CoordinatorGrpcTest.rpcMetricsTest
Why are the changes needed?
HEARTBEAT_METHODis hard to meansure due to async sending at background. So remove itGET_SHUFFLE_ASSIGNMENTS_METHODmay be not calleddescCounterwhen rpc finished, so remove itDoes this PR introduce any user-facing change?
No
How was this patch tested?
Dont need