Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-48][FEATURE][FOLLOW UP] add docs for operator #261

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

wangao1236
Copy link
Collaborator

What changes were proposed in this pull request?

For issue #48
I add docs about design and usage for operator .

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #261 (5737bd3) into master (fc6d49b) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     60.11%   59.70%   -0.42%     
- Complexity     1217     1377     +160     
============================================
  Files           150      166      +16     
  Lines          7602     8916    +1314     
  Branches        718      853     +135     
============================================
+ Hits           4570     5323     +753     
- Misses         2791     3318     +527     
- Partials        241      275      +34     
Impacted Files Coverage Δ
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 21.23% <0.00%> (-1.75%) ⬇️
.../org/apache/uniffle/server/ShuffleTaskManager.java 76.80% <0.00%> (-0.16%) ⬇️
...pache/uniffle/server/ShuffleServerGrpcService.java 0.87% <0.00%> (-0.03%) ⬇️
...e/uniffle/client/factory/ShuffleClientFactory.java 0.00% <0.00%> (ø)
...uniffle/storage/factory/ShuffleHandlerFactory.java 0.00% <0.00%> (ø)
...e/storage/handler/impl/LocalFileDeleteHandler.java 0.00% <0.00%> (ø)
...storage/handler/impl/HdfsShuffleDeleteHandler.java 0.00% <0.00%> (ø)
...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java 0.00% <0.00%> (ø)
...mapreduce/task/reduce/RssInMemoryRemoteMerger.java 75.94% <0.00%> (ø)
...g/apache/hadoop/mapred/SortWriteBufferManager.java 79.89% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zuston
zuston previously approved these changes Oct 12, 2022
Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jerqi
Copy link
Contributor

jerqi commented Oct 12, 2022

Should we put all the docs into the directory docs?

@jerqi
Copy link
Contributor

jerqi commented Oct 12, 2022

Why do we delete the file docs/asset/rss_architecture.png

@wangao1236
Copy link
Collaborator Author

Why do we delete the file docs/asset/rss_architecture.png

Sorry, I may have deleted it by mistake, it has been restored

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 8be8390 into apache:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants