Fix potenial missing reads of exclude nodes #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
============================================
+ Coverage 59.70% 59.73% +0.03%
- Complexity 1377 1378 +1
============================================
Files 166 166
Lines 8916 8918 +2
Branches 853 853
============================================
+ Hits 5323 5327 +4
+ Misses 3318 3317 -1
+ Partials 275 274 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Oct 18, 2022
|
Have you tested this patch by hand? |
Yes. |
kaijchen
pushed a commit
that referenced
this pull request
Nov 12, 2022
### What changes were proposed in this pull request? Use the original latest modification time to fix potenial missing reads of exclude nodes ### Why are the changes needed? I found that after doing `parseExcludeNodesFile(hadoopFileSystem.open(hadoopPath));`, the file was updated of adding the new nodes, in the current implementation, the newly added nodes wont be recognized. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By hand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the original latest modification time to fix potenial missing reads of exclude nodes
Why are the changes needed?
I found that after doing
parseExcludeNodesFile(hadoopFileSystem.open(hadoopPath));, the file was updated of adding the new nodes, in the current implementation, the newly added nodes wont be recognized.Does this PR introduce any user-facing change?
No
How was this patch tested?
Dont need