[ISSUE-273][BUG] Get shuffle result failed caused by concurrent calls to registerShuffle #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage 59.71% 59.71%
Complexity 1377 1377
=========================================
Files 166 166
Lines 8918 8918
Branches 853 853
=========================================
Hits 5325 5325
Misses 3318 3318
Partials 275 275 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
jerqi
changed the title
leixm
changed the title
|
This change is OK for me. Please update the spark3 client. @leixm |
jerqi
changed the title
zuston
approved these changes
Oct 21, 2022
|
Thanks for your contribution @leixm Merged. |
|
@zuston Thank you for your review. |
|
I will back port this pr to 0.6. |
jerqi
pushed a commit
that referenced
this pull request
Oct 21, 2022
… to registerShuffle (#274) What changes were proposed in this pull request? For issue#173, make the lifecycle of remoteStorage var scoped in the method of registerShuffle Why are the changes needed? This problem causes getShuffleResult to fail, which eventually causes the task to fail. Does this PR introduce any user-facing change? No How was this patch tested? Existing UT Co-authored-by: leixianming <leixianming@didiglobal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For issue#173, make the lifecycle of remoteStorage var scoped in the method of registerShuffle
Why are the changes needed?
This problem causes getShuffleResult to fail, which eventually causes the task to fail.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT