Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum type test about case insensitive #280

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

zuston
Copy link
Member

@zuston zuston commented Oct 26, 2022

What changes were proposed in this pull request?

Add enum type test about case insensitive

Why are the changes needed?

The enum type is the case insensitive. This PR is to add some test case to indicate this.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UTs

@zuston
Copy link
Member Author

zuston commented Oct 26, 2022

Minor improvement. @jerqi @frankliee PTAL

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait for CI.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #280 (a157a64) into master (47effb2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #280   +/-   ##
=========================================
  Coverage     59.71%   59.71%           
  Complexity     1377     1377           
=========================================
  Files           166      166           
  Lines          8918     8918           
  Branches        853      853           
=========================================
  Hits           5325     5325           
  Misses         3318     3318           
  Partials        275      275           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit bde8fbb into apache:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants