Add more test cases on LocalStorageManager.selectStorage #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerqi PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
============================================
+ Coverage 60.51% 60.71% +0.19%
- Complexity 1427 1436 +9
============================================
Files 175 175
Lines 9087 9087
Branches 874 874
============================================
+ Hits 5499 5517 +18
+ Misses 3295 3281 -14
+ Partials 293 289 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Nov 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add more test cases on LocalStorageManager.selectStorage
Why are the changes needed?
Currently, the method of LocalStorageManager.selectStorage lacks unit tests, which should be handle with care as storage corruption is involved
Does this PR introduce any user-facing change?
No
How was this patch tested?
Dont need