Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-283][FEATURE] Support snappy compression/decompression #304

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

amaliujia
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds the support of snappy compression/decompression based on the example of #254.

Why are the changes needed?

Add a new feature.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

@amaliujia amaliujia mentioned this pull request Nov 6, 2022
3 tasks
@jerqi jerqi requested a review from zuston November 6, 2022 04:45
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #304 (ac57c13) into master (74949f5) will decrease coverage by 0.05%.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
- Coverage     60.76%   60.70%   -0.06%     
- Complexity     1454     1459       +5     
============================================
  Files           179      180       +1     
  Lines          9201     9223      +22     
  Branches        882      886       +4     
============================================
+ Hits           5591     5599       +8     
- Misses         3316     3325       +9     
- Partials        294      299       +5     
Impacted Files Coverage Δ
...rg/apache/uniffle/common/config/RssClientConf.java 93.75% <ø> (ø)
...apache/uniffle/common/compression/SnappyCodec.java 30.00% <30.00%> (ø)
...a/org/apache/uniffle/common/compression/Codec.java 83.33% <100.00%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi linked an issue Nov 6, 2022 that may be closed by this pull request
3 tasks
@jerqi
Copy link
Contributor

jerqi commented Nov 6, 2022

Should we modify the document about rss.client.io.compression.codec in the https://github.com/apache/incubator-uniffle/blob/master/docs/client_guide.md?

@amaliujia
Copy link
Contributor Author

@jerqi Yes! I updated that config's description accordingly.

@amaliujia
Copy link
Contributor Author

The failing test seems to be flaky. What is the way to re-trigger the test?

@jerqi
Copy link
Contributor

jerqi commented Nov 6, 2022

The failing test seems to be flaky. What is the way to re-trigger the test?

I have re-triggered the test. It passed. You can close and reopen the pr to re-trigger the all the tests. It seems that only committers can re-trigger the single test.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @amaliujia

@jerqi jerqi merged commit fbe3074 into apache:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support snappy
3 participants