[ISSUE-290] Make RpcNodePort and HttpNodePort optional

[amaliujia]

What changes were proposed in this pull request?

This PR makes RPC_SERVER_PORT and JETTY_HTTP_PORT in RSS conf as optional by setting up default values into the config entries.

Why are the changes needed?

Feature.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

UT

[amaliujia]

The design.md in fact mentions two values for each port config entry:

    # RpcNodePort represents the port required by the rpc protocol of the coordinators,
    # and the range is the same as the port range of the NodePort type service in kubernetes.
    # By default, we will deploy two coordinators to ensure active-active.
    rpcNodePort:
      - 30001
      - 30011
    # httpNodePort represents the port required by the http protocol of the coordinators,
    # and the range is the same as the port range of the NodePort type service in kubernetes.
    # By default, we will deploy two coordinators to ensure active-active.
    httpNodePort:
      - 30002
      - 30012

However I didn't see two usages in the codebase. Maybe I have missed something?

[jerqi]

We only provide the default value in the configuration. https://github.com/apache/incubator-uniffle/blob/master/conf/server.conf and https://github.com/apache/incubator-uniffle/blob/master/conf/coordinator.conf

rss.rpc.server.port 19999
rss.jetty.http.port 19998

design.md is only the Kubernetes Operator design document.

[amaliujia]

I see it better now. Made a change to have the default value in config entries match the values in the provided config file.

[codecov-commenter]

Codecov Report

Merging #305 (d63d191) into master (fbe3074) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #305   +/-   ##
=========================================
  Coverage     60.70%   60.70%           
  Complexity     1459     1459           
=========================================
  Files           180      180           
  Lines          9223     9223           
  Branches        886      886           
=========================================
  Hits           5599     5599           
  Misses         3325     3325           
  Partials        299      299           

Impacted Files	Coverage Δ
.../org/apache/uniffle/common/config/RssBaseConf.java	93.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jerqi]

LGTM, thanks @amaliujia @zuston

[jerqi]

Do you want to join our Wechat group? You can scan the QR code