-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-300] Make config type of RSS_CLIENT_TYPE as enum #310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=========================================
Coverage 58.46% 58.47%
- Complexity 1572 1573 +1
=========================================
Files 193 194 +1
Lines 10846 10848 +2
Branches 954 954
=========================================
+ Hits 6341 6343 +2
Misses 4131 4131
Partials 374 374
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
server/src/main/java/org/apache/uniffle/server/RegisterHeartBeat.java
Outdated
Show resolved
Hide resolved
@selectbook Will you continue this pr? |
yeah, i will continue to fix it from this night |
@selectbook Ok, take your time. |
@selectbook Gently ping. |
@selectbook Maybe you're busy now, I help you solve the code style and review issues. I hope you don't mind it. This pr is related to #133. I hope this pr can be merged quickly. |
Merged. Thanks @selectbook @jerqi . |
I'm sorry I've been really busy recently. Thanks for your patience |
What changes were proposed in this pull request?
move the ClentType.java from internal-client module to common module
change stringType to enumType for RSS_CLIENT_TYPE in the RssBaseConf.java
use name method convert ShuffleServerConf.RSS_CLIENT_TYPE to String(I am not sure if this is the right way)
Why are the changes needed?
Easy to add different extensions #300
Does this PR introduce any user-facing change?
No
How was this patch tested?
Already added