Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of "Comparison method violates its general contract" #315

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Nov 12, 2022

What changes were proposed in this pull request?

Fix bug of "Comparison method violates its general contract"

Why are the changes needed?

If not, it will throw the exception when using the timsort.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Dont need

Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston for the fix.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #315 (c6206cb) into master (84f781f) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #315   +/-   ##
=========================================
  Coverage     61.01%   61.01%           
  Complexity     1489     1489           
=========================================
  Files           185      185           
  Lines          9314     9314           
  Branches        900      900           
=========================================
  Hits           5683     5683           
  Misses         3326     3326           
  Partials        305      305           
Impacted Files Coverage Δ
...rg/apache/uniffle/server/buffer/ShuffleBuffer.java 91.15% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 4a3d2be into apache:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants