[AQE][LocalOrder] Fix potenial bug when merging continuous segments #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuston
changed the title
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
============================================
+ Coverage 61.01% 61.07% +0.05%
- Complexity 1489 1493 +4
============================================
Files 185 185
Lines 9314 9327 +13
Branches 900 903 +3
============================================
+ Hits 5683 5696 +13
Misses 3326 3326
Partials 305 305
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
previously approved these changes
Nov 13, 2022
|
Ci failed due to the unstable network. |
jerqi
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
In current codebase, while expected task id is 230 but splitting the index taskId seq of (229, 230, 221, 229, 230), it will throw exception of discontinuous check.
This PR is to fix this
Does this PR introduce any user-facing change?
No
How was this patch tested?