Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support the estimated number of ShuffleServers required. #322

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Nov 14, 2022

What changes were proposed in this pull request?

Estimated number of ShuffleServers required.

Why are the changes needed?

Avoid manually specifying the number of ShuffleServers to improve user experience.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

UT.

@jerqi jerqi requested a review from zuston November 14, 2022 06:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #322 (b00c2d9) into master (84f781f) will increase coverage by 0.16%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
+ Coverage     61.01%   61.17%   +0.16%     
- Complexity     1489     1503      +14     
============================================
  Files           185      185              
  Lines          9314     9356      +42     
  Branches        900      908       +8     
============================================
+ Hits           5683     5724      +41     
  Misses         3326     3326              
- Partials        305      306       +1     
Impacted Files Coverage Δ
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java 23.07% <ø> (ø)
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <0.00%> (ø)
...rg/apache/uniffle/client/util/RssClientConfig.java 0.00% <ø> (ø)
...java/org/apache/uniffle/common/util/Constants.java 0.00% <0.00%> (ø)
...org/apache/spark/shuffle/RssSparkShuffleUtils.java 57.14% <85.71%> (+2.59%) ⬆️
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java 44.00% <100.00%> (+12.29%) ⬆️
.../java/org/apache/spark/shuffle/RssSparkConfig.java 93.61% <100.00%> (+0.13%) ⬆️
...ffle/common/segment/LocalOrderSegmentSplitter.java 90.62% <0.00%> (+2.38%) ⬆️
...che/uniffle/client/impl/ShuffleReadClientImpl.java 90.09% <0.00%> (+2.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zuston Do you have other suggestion?

@zuston
Copy link
Member

zuston commented Nov 15, 2022

LGTM, @zuston Do you have other suggestion?

Let me take a look.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuston zuston merged commit 70076fa into apache:master Nov 15, 2022
@zuston
Copy link
Member

zuston commented Nov 15, 2022

Merged. Thanks @leixm @jerqi .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants