[BUG] Fix incorrect spark metrics #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
============================================
+ Coverage 61.21% 61.32% +0.11%
- Complexity 1506 1526 +20
============================================
Files 185 186 +1
Lines 9360 9441 +81
Branches 908 924 +16
============================================
+ Hits 5730 5790 +60
- Misses 3325 3341 +16
- Partials 305 310 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Nov 15, 2022
...gration-test/spark-common/src/test/java/org/apache/uniffle/test/WriteAndReadMetricsTest.java
Outdated
Show resolved
Hide resolved
|
I'm confused that the |
|
Could you debug in your local machine? |
Fixed @jerqi PTAL |
jerqi
approved these changes
Nov 18, 2022
kaijchen
added a commit
to kaijchen/incubator-uniffle
that referenced
this pull request
Nov 18, 2022
Fix incorrect spark metrics 1. The corresponding shuffle-read records number and shuffle-write records number is not consistent in our internal cluster 2. Log wont show the correct fetch bytes, always return 0 like `22/11/15 13:54:53 INFO RssShuffleDataIterator: Fetch 0 bytes cost 30791 ms and 53 ms to serialize, 347 ms to decompress with unCompressionLength[274815736] ` No 1. UTs 2. Online spark3 jobs test Co-authored-by: Kaijie Chen <ckj@apache.org>
kaijchen
pushed a commit
that referenced
this pull request
Nov 18, 2022
Fix incorrect spark metrics 1. The corresponding shuffle-read records number and shuffle-write records number is not consistent in our internal cluster 2. Log wont show the correct fetch bytes, always return 0 like `22/11/15 13:54:53 INFO RssShuffleDataIterator: Fetch 0 bytes cost 30791 ms and 53 ms to serialize, 347 ms to decompress with unCompressionLength[274815736] ` No 1. UTs 2. Online spark3 jobs test
jerqi
reviewed
Nov 21, 2022
| import org.junit.jupiter.api.Test; | ||
| import scala.collection.Seq; | ||
|
|
||
| public class WriteAndReadMetricsTest extends SimpleTestBase { |
There was a problem hiding this comment.
The test case seems flaky
https://github.com/apache/incubator-uniffle/actions/runs/3511234782/jobs/5881817090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect spark metrics
Why are the changes needed?
22/11/15 13:54:53 INFO RssShuffleDataIterator: Fetch 0 bytes cost 30791 ms and 53 ms to serialize, 347 ms to decompress with unCompressionLength[274815736]Does this PR introduce any user-facing change?
No
How was this patch tested?