Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix invalid owner of host path volumes #330

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

wangao1236
Copy link
Collaborator

@wangao1236 wangao1236 commented Nov 16, 2022

What changes were proposed in this pull request?

fix #323
I have modified it for time reasons, thanks for pointing this out.
I changed the owner of host paths as UID:GID.

Why are the changes needed?

Fix bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #330 (ef00f32) into master (7aa0117) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     61.09%   61.21%   +0.12%     
- Complexity     1494     1506      +12     
============================================
  Files           185      185              
  Lines          9325     9360      +35     
  Branches        903      908       +5     
============================================
+ Hits           5697     5730      +33     
- Misses         3323     3325       +2     
  Partials        305      305              
Impacted Files Coverage Δ
...java/org/apache/uniffle/common/util/Constants.java 0.00% <0.00%> (ø)
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java 23.07% <0.00%> (ø)
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <0.00%> (ø)
.../java/org/apache/spark/shuffle/RssSparkConfig.java 93.61% <0.00%> (+0.13%) ⬆️
...org/apache/spark/shuffle/RssSparkShuffleUtils.java 57.14% <0.00%> (+2.59%) ⬆️
...iffle/common/segment/FixedSizeSegmentSplitter.java 95.55% <0.00%> (+5.31%) ⬆️
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java 44.00% <0.00%> (+12.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wangao1236

@jerqi jerqi merged commit 87361da into apache:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Log host path access denied when UID is different from GID
3 participants