Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-329]Catch NPE in ShuffleTaskManager#addFinishedBlockIds #331

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

xianjingfeng
Copy link
Member

@xianjingfeng xianjingfeng commented Nov 16, 2022

What changes were proposed in this pull request?

If app expired, thrown a runtime exception with message

Why are the changes needed?

reportShuffleResult after app expired in shuffle server will throw NPE #329

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xianjingfeng

@jerqi jerqi merged commit 9f0610a into apache:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Catch NPE in org.apache.uniffle.server.ShuffleTaskManager#addFinishedBlockIds
2 participants