[ISSUE-342][Improvement] Check Spark Serializer type

[chong0929]

What changes were proposed in this pull request?

Spark have multiple serializers. We support the spark serializer which supportsRelocationOfSerializedObjects.
You can see https://github.com/apache/spark/blob/25849684b78cca6651e25d6efc9644a576e7e20f/core/src/main/scala/org/apache/spark/serializer/Serializer.scala#L98

Spark have three kinds of serializer
org.apache.spark.serializer.JavaSerializer
org.apache.spark.sql.execution.UnsafeRowSerializer
org.apache.spark.serializer.KryoSerializer
Only org.apache.spark.serializer.JavaSerializer don't support RelocationOfSerializedObjects.

Why are the changes needed?

So when we find the parameters to use org.apache.spark.serializer.JavaSerializer, We should throw an exception.

Does this PR introduce any user-facing change?

No

How was this patch tested?

test locally

[chong0929]

@jerqi Hi, would you mind to take a look?

[jerqi]

@jerqi Hi, would you mind to take a look?

Please fix code style and compile error.

[codecov-commenter]

Codecov Report

Merging #344 (4c2422e) into master (d09b40b) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #344      +/-   ##
============================================
+ Coverage     58.17%   58.22%   +0.04%     
  Complexity     1529     1529              
============================================
  Files           192      191       -1     
  Lines         10606    10597       -9     
  Branches        924      924              
============================================
  Hits           6170     6170              
+ Misses         4068     4059       -9     
  Partials        368      368              

Impacted Files	Coverage Δ
...ava/org/apache/uniffle/common/RssShuffleUtils.java

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jerqi]

you can click the failure pipeline https://github.com/apache/incubator-uniffle/actions/runs/3507622551/jobs/5875494928 and then you can see

You should fix these code style issues.

[jerqi]

We should modify the test org.apache.uniffle.test.GetReaderTest, the test use the JavaSerializer. We should change it. https://github.com/apache/incubator-uniffle/actions/runs/3507622551/jobs/5875494954

[zuston]

you can click the failure pipeline https://github.com/apache/incubator-uniffle/actions/runs/3507622551/jobs/5875494928 and then you can see You should fix these code style issues.

You could import the uniffle codestyle into the IDEA, following this guide https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md#code-style-guide @chong0929

[chong0929]

We should modify the test org.apache.uniffle.test.GetReaderTest, the test use the JavaSerializer. We should change it. https://github.com/apache/incubator-uniffle/actions/runs/3507622551/jobs/5875494954

Thanks for you review, add a default conf about spark.serializer which shoule be KryoSerializer when in PBS.

[chong0929]

you can click the failure pipeline https://github.com/apache/incubator-uniffle/actions/runs/3507622551/jobs/5875494928 and then you can see You should fix these code style issues.

You could import the uniffle codestyle into the IDEA, following this guide https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md#code-style-guide @chong0929

Thanks you for your reminder and suggestion, I'm trying to make some changes.

[jerqi]

Spark3 also have org.apache.uniffle.test.GetReaderTest, you should also modify it.

[jerqi]

LGTM, thanks @chong0929 @zuston . Great work!