Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][FOLLOWUP] Fix flaky test of AQESkewedJoinWithLocalOrderTest #355

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Nov 23, 2022

What changes were proposed in this pull request?

Fix flaky test of AQESkewedJoinWithLocalOrderTest

Why are the changes needed?

  1. The sparksession is not closed by GetReaderTest.java

Does this PR introduce any user-facing change?

No

How was this patch tested?

@zuston zuston requested a review from jerqi November 23, 2022 10:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #355 (b3232ae) into master (72ef4e3) will increase coverage by 4.45%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
+ Coverage     58.42%   62.88%   +4.45%     
+ Complexity     1554     1426     -128     
============================================
  Files           193      174      -19     
  Lines         10758     8330    -2428     
  Branches        935      814     -121     
============================================
- Hits           6285     5238    -1047     
+ Misses         4102     2812    -1290     
+ Partials        371      280      -91     
Impacted Files Coverage Δ
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
...preduce/task/reduce/RssRemoteMergeManagerImpl.java
deploy/kubernetes/operator/pkg/webhook/manager.go
...mapreduce/task/reduce/RssInMemoryRemoteMerger.java
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java
...java/org/apache/hadoop/mapred/SortWriteBuffer.java
...y/kubernetes/operator/pkg/webhook/inspector/rss.go
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi
Copy link
Contributor

jerqi commented Nov 23, 2022

企业微信截图_7311e920-d4d2-4563-a673-bd869c86b73d

Kerberos flaky test. Old problem.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@jerqi jerqi merged commit 16a63e2 into apache:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants