Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-339] Optimize retry logic in send shuffle data #361

Merged
merged 3 commits into from
Nov 27, 2022

Conversation

xianjingfeng
Copy link
Member

What changes were proposed in this pull request?

  1. Set the default value of rss.client.retry.max to 50
  2. Set rss.client.retry.max to rss.client.retry.max/2 if replica > replicaWrite
  3. Throw an exception if rss.client.retry.max * rss.client.retry.interval.max > rss.client.send.check.timeout.ms

Why are the changes needed?

More reasonable. #339

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added

@jerqi jerqi linked an issue Nov 27, 2022 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #361 (62e7ff7) into master (57a834b) will increase coverage by 0.13%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##             master     #361      +/-   ##
============================================
+ Coverage     58.46%   58.59%   +0.13%     
- Complexity     1572     1579       +7     
============================================
  Files           193      193              
  Lines         10846    10869      +23     
  Branches        954      956       +2     
============================================
+ Hits           6341     6369      +28     
+ Misses         4131     4126       -5     
  Partials        374      374              
Impacted Files Coverage Δ
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <0.00%> (ø)
...e/uniffle/client/factory/ShuffleClientFactory.java 0.00% <0.00%> (ø)
...rg/apache/uniffle/client/util/RssClientConfig.java 0.00% <ø> (ø)
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java 50.45% <100.00%> (+6.45%) ⬆️
...org/apache/spark/shuffle/RssSparkShuffleUtils.java 68.42% <100.00%> (+11.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xianjingfeng , wait for CI

@jerqi jerqi merged commit 1f2953a into apache:master Nov 27, 2022
@jerqi
Copy link
Contributor

jerqi commented Nov 27, 2022

Merged.

@xianjingfeng xianjingfeng deleted the issue_339 branch March 1, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Optimize retry logic in ShuffleServerGrpcClient#sendShuffleData
3 participants