Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable spotbugs and fix high priority bugs #38

Merged
merged 21 commits into from
Jul 13, 2022
Merged

Enable spotbugs and fix high priority bugs #38

merged 21 commits into from
Jul 13, 2022

Commits on Jul 8, 2022

  1. Set spotbugs threshold to high

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    14c73ee View commit details
    Browse the repository at this point in the history

  2. BufferSegment defines equals and uses Object.hashCode()

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    bf65108 View commit details
    Browse the repository at this point in the history

  3. ShufflePartitionedBlock defines equals and uses Object.hashCode()

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    a0594c3 View commit details
    Browse the repository at this point in the history

  4. Compare array content instead of reference in ShufflePartitionedBlock

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    a994cff View commit details
    Browse the repository at this point in the history

  5. Invocation of toString on ShufflePartitionedData.blockList

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    d294467 View commit details
    Browse the repository at this point in the history

  6. ConfigOption defines equals and uses Object.hashCode()

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    8271252 View commit details
    Browse the repository at this point in the history

  7. Public static field in ConfigUtils should be final

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    08a88bf View commit details
    Browse the repository at this point in the history

  8. RssConf defines clone() but doesn't implement Cloneable

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    190cdde View commit details
    Browse the repository at this point in the history

  9. Invocation of toString on ipPort

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    d52bd21 View commit details
    Browse the repository at this point in the history

  10. Reliance on default encoding in SimpleClusterManager

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    ffa7dae View commit details
    Browse the repository at this point in the history

  11. Public static field in FileBasedShuffleSegment should be final

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    c6abc7c View commit details
    Browse the repository at this point in the history

  12. Reliance on default encoding in ShuffleStorageUtils

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    161280b View commit details
    Browse the repository at this point in the history

  13. Random object created and used only once in LocalStorageChecker

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    ac20a92 View commit details
    Browse the repository at this point in the history

  14. public static field should be final in ShuffleFlushManager

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    76c3cd8 View commit details
    Browse the repository at this point in the history

  15. Fix checkstyle

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    ab77201 View commit details
    Browse the repository at this point in the history

  16. public static field should be final in RssMRConfig

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    8f0e85c View commit details
    Browse the repository at this point in the history

  17. Fixup RssConf#clone()

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    0979fda View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into spotbugs

    @kaijchen
    kaijchen committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    6899a3c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Merge branch 'apache:master' into spotbugs

    @kaijchen
    kaijchen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    4676e54 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into spotbugs

    @kaijchen
    kaijchen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    eea4158 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Merge branch 'master' into spotbugs

    @kaijchen
    kaijchen committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4288a2f View commit details
    Browse the repository at this point in the history