Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-376] Fix concurrency problems may occur when the ApplicationManager register app #382

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

smallzhongfeng
Copy link
Contributor

@smallzhongfeng smallzhongfeng commented Dec 1, 2022

What changes were proposed in this pull request?

Lock when reading and writing the map appAndTimes.

Why are the changes needed?

To resolve #376 .

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Passed origin uts.

@smallzhongfeng smallzhongfeng changed the title [ISSUE-376] Fix concurrency problems may occur when the ApplicationMa… [ISSUE-376] Fix concurrency problems may occur when the ApplicationManager refresh app Dec 1, 2022
@smallzhongfeng smallzhongfeng changed the title [ISSUE-376] Fix concurrency problems may occur when the ApplicationManager refresh app [ISSUE-376] Fix concurrency problems may occur when the ApplicationManager register app Dec 1, 2022
@jerqi jerqi requested a review from leixm December 1, 2022 15:19
@jerqi
Copy link
Contributor

jerqi commented Dec 1, 2022

cc @leixm Could you help me review this patch?
If you feel that this patch is ok, you approve this pr and say LGTM. (LGTM means that look good to me)
企业微信截图_f7523cc6-f4c4-423f-900b-b916fac58ad6

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #382 (c21fde6) into master (57a834b) will increase coverage by 0.17%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master     #382      +/-   ##
============================================
+ Coverage     58.46%   58.63%   +0.17%     
- Complexity     1572     1590      +18     
============================================
  Files           193      193              
  Lines         10846    10920      +74     
  Branches        954      958       +4     
============================================
+ Hits           6341     6403      +62     
- Misses         4131     4138       +7     
- Partials        374      379       +5     
Impacted Files Coverage Δ
...apache/uniffle/coordinator/ApplicationManager.java 84.11% <33.33%> (-1.35%) ⬇️
...apache/uniffle/coordinator/AccessQuotaChecker.java 94.73% <85.71%> (-1.10%) ⬇️
...a/org/apache/uniffle/coordinator/QuotaManager.java 89.55% <100.00%> (+7.55%) ⬆️
...a/org/apache/uniffle/common/ShuffleServerInfo.java 75.00% <0.00%> (-25.00%) ⬇️
...orage/handler/impl/LocalFileClientReadHandler.java 59.37% <0.00%> (-6.15%) ⬇️
...va/org/apache/uniffle/client/util/ClientUtils.java 52.27% <0.00%> (-5.23%) ⬇️
.../java/org/apache/uniffle/common/util/RssUtils.java 60.58% <0.00%> (-2.78%) ⬇️
...le/storage/handler/impl/HdfsClientReadHandler.java 75.00% <0.00%> (-1.93%) ⬇️
...che/uniffle/client/impl/ShuffleReadClientImpl.java 88.46% <0.00%> (-1.64%) ⬇️
.../java/org/apache/uniffle/server/ShuffleServer.java 67.39% <0.00%> (-1.03%) ⬇️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallzhongfeng
Copy link
Contributor Author

cc @jerqi @leixm

@jerqi
Copy link
Contributor

jerqi commented Dec 3, 2022

LGTM, @leixm Do you have another suggestion?

@leixm
Copy link
Contributor

leixm commented Dec 3, 2022

+1 LGTM.

@jerqi
Copy link
Contributor

jerqi commented Dec 3, 2022

@leixm You could click the approve button.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged. thanks @leixm @smallzhongfeng

@jerqi jerqi merged commit 9a552b4 into apache:master Dec 3, 2022
@smallzhongfeng
Copy link
Contributor Author

Thanks all. @jerqi @leixm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Concurrency problems may occur when the ApplicationManager registerApplicationInfo
4 participants