-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-376] Fix concurrency problems may occur when the ApplicationManager register app #382
Conversation
…nager refresh app
cc @leixm Could you help me review this patch? |
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
============================================
+ Coverage 58.46% 58.63% +0.17%
- Complexity 1572 1590 +18
============================================
Files 193 193
Lines 10846 10920 +74
Branches 954 958 +4
============================================
+ Hits 6341 6403 +62
- Misses 4131 4138 +7
- Partials 374 379 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM, @leixm Do you have another suggestion? |
+1 LGTM. |
@leixm You could click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged. thanks @leixm @smallzhongfeng
What changes were proposed in this pull request?
Lock when reading and writing the map
appAndTimes
.Why are the changes needed?
To resolve #376 .
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Passed origin uts.