-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-388][ISSUE-244][Bug] Fix incorrect usage of GRPCMetrics#setGauge
#404
Conversation
Could you explain why it will cause these problems? |
Thread1: activeThreadSize.incrementAndGet() |
common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
============================================
- Coverage 59.20% 58.57% -0.64%
- Complexity 1471 1608 +137
============================================
Files 181 194 +13
Lines 9705 10996 +1291
Branches 839 963 +124
============================================
+ Hits 5746 6441 +695
- Misses 3612 4174 +562
- Partials 347 381 +34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Got it. |
GRPCMetrics#setGauge
GRPCMetrics#setGauge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xianjingfeng
Make sense. A problem: Gauge is thread safe? |
Yes, it use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Fix incorrect usage of
GRPCMetrics#setGauge
Why are the changes needed?
It is a bug #244 #388
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need