Fix incorrect metrics of event_queue_size and total_write_handler #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=========================================
Coverage 58.54% 58.54%
Complexity 1611 1611
=========================================
Files 195 195
Lines 11035 11035
Branches 966 966
=========================================
Hits 6460 6460
Misses 4195 4195
Partials 380 380
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Merged. Thanks @jerqi |
kaijchen
pushed a commit
that referenced
this pull request
Jan 17, 2023
### What changes were proposed in this pull request? Fix incorrect metrics of event_queue_size and total_write_handler ### Why are the changes needed? In current codebase, there are bugs on above metrics. 1. The metric of total_write_handler won't desc when exception happened on flushing to file 2. The metric of event_queue_size won't show the correct wait queue size. In original logic, if all events are waiting to be operated in flush thread pool, the flushQueue is always 0 and the metric value also will be 0. This is wrong. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Don't need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect metrics of event_queue_size and total_write_handler
Why are the changes needed?
In current codebase, there are bugs on above metrics.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Don't need.