-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-169] Support metric reporter and Support promethues push gateway #415
Conversation
# Conflicts: # coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
============================================
+ Coverage 58.54% 58.62% +0.08%
- Complexity 1611 1632 +21
============================================
Files 195 198 +3
Lines 11035 11130 +95
Branches 966 986 +20
============================================
+ Hits 6460 6525 +65
- Misses 4195 4218 +23
- Partials 380 387 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Could we add some docs about this feature? |
Yes |
common/src/main/java/org/apache/uniffle/common/metrics/MetricReporterFactory.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/metrics/MetricReporterFactory.java
Show resolved
Hide resolved
...n/java/org/apache/uniffle/common/metrics/prometheus/PrometheusPushGatewayMetricReporter.java
Show resolved
Hide resolved
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java
Outdated
Show resolved
Hide resolved
Is this pr ready for review? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @advancedxy do you have another suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @advancedxy @xianjingfeng |
What changes were proposed in this pull request?
Support metric reporter and Support promethues push gateway
Why are the changes needed?
Users can implement custom export plugin to export metrics to their monitoring system. #169
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT