Improve README #427
Merged
Improve README #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
============================================
- Coverage 58.41% 57.61% -0.81%
+ Complexity 1612 1393 -219
============================================
Files 195 173 -22
Lines 11063 9223 -1840
Branches 976 816 -160
============================================
- Hits 6463 5314 -1149
+ Misses 4221 3573 -648
+ Partials 379 336 -43 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Dec 15, 2022
README.md
Outdated
|
|
||
| Coordinator will collect status of shuffle server and do the assignment for the job. | ||
| Coordinator will collect the status of the shuffle server and do the assignment for the job. |
There was a problem hiding this comment.
How about this?
Coordinator will collect the status of the shuffle server and calculate shuffle assignments for compute job/app based on various assignment strategy.
There was a problem hiding this comment.
How about "Coordinator will collect the status of shuffle servers and assign jobs based on some strategy."?
|
In addition, I have tweaked the following sentence: |
advancedxy
approved these changes
Dec 15, 2022
jerqi
approved these changes
Dec 15, 2022
kaijchen
added a commit
that referenced
this pull request
Jan 17, 2023
1. Update the introduction section in README:
* "compute engines" is changed to "distributed compute engines".
* "MapReduce" is changed to "Apache Hadoop MapReduce".
* Remove the "Total lines" badge, see [OSSInsight][1] for better insight.
2. Fix typos.
[1]: https://ossinsight.io/analyze/apache/incubator-uniffle#lines-of-code-changed "apache/incubator-uniffle | OSSInsight"
Improve the README.
No.
Preview: https://github.com/kaijchen/incubator-uniffle/tree/readme#apache-uniffle-incubating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Improve the README.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Preview: https://github.com/kaijchen/incubator-uniffle/tree/readme#apache-uniffle-incubating