Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] Remove unused methods in Storage interface #431

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Dec 16, 2022

What changes were proposed in this pull request?

  1. Remove unused methods in Storage interface

Why are the changes needed?

  1. Remove it to make more clear.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Don't need

@zuston zuston requested a review from jerqi December 16, 2022 06:32
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #431 (d81b5c3) into master (4bd3af6) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #431      +/-   ##
============================================
+ Coverage     58.44%   58.52%   +0.07%     
  Complexity     1613     1613              
============================================
  Files           195      195              
  Lines         11057    11042      -15     
  Branches        976      973       -3     
============================================
  Hits           6462     6462              
+ Misses         4217     4202      -15     
  Partials        378      378              
Impacted Files Coverage Δ
...apache/uniffle/storage/common/AbstractStorage.java 51.35% <ø> (+5.00%) ⬆️
...org/apache/uniffle/storage/common/HdfsStorage.java 0.00% <ø> (ø)
...rg/apache/uniffle/storage/common/LocalStorage.java 45.89% <ø> (+2.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston zuston merged commit d897059 into apache:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants