[Minor] refactor test code #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
commented
Dec 16, 2022
| ShuffleServerConf conf = new ShuffleServerConf(); | ||
| conf.setBoolean(ShuffleServerConf.HEALTH_CHECK_ENABLE, true); | ||
| conf.setString(ShuffleServerConf.RSS_STORAGE_TYPE, StorageType.LOCALFILE.name()); | ||
| conf.set(ShuffleServerConf.RSS_STORAGE_BASE_PATH, Arrays.asList("st1", "st2", "st3")); |
There was a problem hiding this comment.
This creates empty dirs: st1,st2,st3 under repo dir when running in IDEs.
There was a problem hiding this comment.
You are right. Could u help do some cleanup after test finished?
There was a problem hiding this comment.
After this change. The st1, st2, st3 should be deleted automatically since they are guarded by the @TempDir annotation.
Is there anything I'm missing here?
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
============================================
+ Coverage 58.53% 58.61% +0.07%
- Complexity 1615 1619 +4
============================================
Files 195 195
Lines 11042 11044 +2
Branches 973 973
============================================
+ Hits 6463 6473 +10
+ Misses 4202 4195 -7
+ Partials 377 376 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
previously approved these changes
Dec 16, 2022
advancedxy
force-pushed
the
test_refactor
branch
from
0798d88
to
7e008dc
Compare
advancedxy
changed the title
|
Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor some test code
Why are the changes needed?
For better code quality. And fixes some flaky test such as #388
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs. There should be no logic change.