Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test: AppBalanceSelectStorageStrategyTest#selectStorageTest #438

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

smallzhongfeng
Copy link
Contributor

@smallzhongfeng smallzhongfeng commented Dec 18, 2022

What changes were proposed in this pull request?

To avoid the possible exception of reading and writing hdfs files during the test, we must ensure that hdfs://path1 and hdfs://path2 are all normal paths.

Why are the changes needed?

for issue #430

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Passed uts.

@smallzhongfeng
Copy link
Contributor Author

PTAl. @zuston

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #438 (8c7bc0c) into master (d897059) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage     58.52%   58.53%           
- Complexity     1613     1615    +2     
=========================================
  Files           195      195           
  Lines         11042    11042           
  Branches        973      973           
=========================================
+ Hits           6462     6463    +1     
  Misses         4202     4202           
+ Partials        378      377    -1     
Impacted Files Coverage Δ
...ategy/storage/AppBalanceSelectStorageStrategy.java 74.00% <0.00%> (+2.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston zuston merged commit 81d23c0 into apache:master Dec 18, 2022
@zuston
Copy link
Member

zuston commented Dec 18, 2022

Thanks @smallzhongfeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants