Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Move GrpcServerTest to common.rpc package #439

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Move GrpcServerTest to common.rpc package.

Why are the changes needed?

GrpcServer is in common.rpc package.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen kaijchen requested a review from zuston December 18, 2022 14:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #439 (6bc520d) into master (81d23c0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #439   +/-   ##
=========================================
  Coverage     58.52%   58.52%           
  Complexity     1614     1614           
=========================================
  Files           195      195           
  Lines         11042    11042           
  Branches        973      973           
=========================================
  Hits           6462     6462           
  Misses         4202     4202           
  Partials        378      378           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaijchen kaijchen merged commit 7b633c0 into apache:master Dec 18, 2022
@kaijchen kaijchen deleted the gst branch December 18, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants