[ISSUE-451][Improvement] Read HDFS data files with random sequence to distribute pressure #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
============================================
- Coverage 58.72% 58.67% -0.05%
- Complexity 1652 1654 +2
============================================
Files 199 199
Lines 11214 11217 +3
Branches 996 997 +1
============================================
- Hits 6585 6582 -3
- Misses 4237 4243 +6
Partials 392 392
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Dec 30, 2022
| @@ -143,7 +143,7 @@ protected void init(String fullShufflePath) { | |||
| LOG.warn("Can't create ShuffleReaderHandler for " + filePrefix, e); | |||
| } | |||
| } | |||
| readHandlers.sort(Comparator.comparing(HdfsShuffleReadHandler::getFilePrefix)); | |||
| Collections.shuffle(readHandlers); | |||
There was a problem hiding this comment.
Could we print the file names? It's important for us to know the order.
jerqi
approved these changes
Jan 3, 2023
3 tasks
jerqi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[Improvement] Read HDFS data files with random sequence to distribute pressure #452
Why are the changes needed?
In PR #396 to support concurrently writing single partition's data into multiple HDFS files, it's better to randomly read HDFS data files to distribute stress in client side.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs