Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] reduce compiler warnings #46

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

advancedxy
Copy link
Contributor

What changes were proposed in this pull request?

  1. reduce the raw use of parameterized class
  2. use Collections.singletonList instead of Arrays.asList for single element
  3. add type annotation for some method signature and variable declaration

Why are the changes needed?

This makes javac and IntelliJ's compiler happy

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Existing tests should be sufficient.

This makes javac and IntelliJ's compiler happy
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #46 (c9b9f8d) into master (ae674a6) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     56.87%   56.87%           
  Complexity     1207     1207           
=========================================
  Files           152      152           
  Lines          8429     8429           
  Branches        816      816           
=========================================
  Hits           4794     4794           
  Misses         3376     3376           
  Partials        259      259           
Impacted Files Coverage Δ
.../org/apache/uniffle/common/config/ConfigUtils.java 22.36% <0.00%> (ø)
.../org/apache/uniffle/common/config/RssBaseConf.java 91.80% <0.00%> (ø)
...ava/org/apache/uniffle/server/ShuffleUploader.java 80.98% <ø> (ø)
...rg/apache/uniffle/common/config/ConfigOptions.java 91.37% <100.00%> (ø)
...rg/apache/uniffle/coordinator/CoordinatorConf.java 96.15% <100.00%> (ø)
...a/org/apache/uniffle/server/ShuffleServerConf.java 99.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae674a6...c9b9f8d. Read the comment docs.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@jerqi jerqi merged commit 1be8451 into apache:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants