[Deps] Bump slf4j to 1.7.36 to fix vulnerability in slf4j-log4j12 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slf4j-log4j12:1.7.25 provides transitive vulnerable dependency log4j:1.2.17 * CVE-2019-17571 9.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation * CVE-2021-4104 7.5 Deserialization of Untrusted Data vulnerability with medium severity found * CVE-2022-23302 8.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation * CVE-2022-23305 9.8 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection') vulnerability pending CVSS allocation * CVE-2022-23307 8.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation
kaijchen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
=========================================
Coverage 58.75% 58.75%
Complexity 1666 1666
=========================================
Files 199 199
Lines 11239 11239
Branches 1000 1000
=========================================
Hits 6604 6604
Misses 4243 4243
Partials 392 392 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
Jan 10, 2023
|
Does this mean we are getting rid of When I was working on spark code, I noticed spark still depends on |
Will it be a problem? |
if we cannot get rid of P.S: I have no objection for merging this PR. |
We can't control the Spark. We only need to guarantee that rss service don't have the danger. And Uniffle can be used for multiple frameworks. |
The problem is that if we are depending on the big data ecosystem, there might be no good way to avoid this. A quick https://issues.apache.org/jira/browse/HADOOP-16206 https://issues.apache.org/jira/browse/HADOOP-12956 Seems that there's no good way for hadoop to get rid of log4j 1x |
|
But I'm in favor of merging this. Let's get rid of log4j 1.x as much as possible. |
jerqi
approved these changes
Jan 11, 2023
|
Merged. thanks @kaijchen @zuston @advancedxy |
kaijchen
added a commit
that referenced
this pull request
Jan 17, 2023
### What changes were proposed in this pull request? Bump slf4j to 1.7.36 to fix vulnerability in slf4j-log4j12. Btw, slf4j:1.7.36 depends on reload4j:1.2.19 instead of log4j. ### Why are the changes needed? slf4j-log4j12:1.7.25 provides transitive vulnerable dependency log4j:1.2.17 * CVE-2019-17571 9.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation * CVE-2021-4104 7.5 Deserialization of Untrusted Data vulnerability with medium severity found * CVE-2022-23302 8.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation * CVE-2022-23305 9.8 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection') vulnerability pending CVSS allocation * CVE-2022-23307 8.8 Deserialization of Untrusted Data vulnerability pending CVSS allocation ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump slf4j to 1.7.36 to fix vulnerability in slf4j-log4j12.
Btw, slf4j:1.7.36 depends on reload4j:1.2.19 instead of log4j.
Why are the changes needed?
slf4j-log4j12:1.7.25 provides transitive vulnerable dependency log4j:1.2.17
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.