[ISSUE-472] Fix Flaky Test: LocalFileServerReadHandlerTest#testDataInconsistent #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=========================================
Coverage 58.78% 58.78%
Complexity 1704 1704
=========================================
Files 206 206
Lines 11471 11471
Branches 1024 1024
=========================================
Hits 6743 6743
Misses 4317 4317
Partials 411 411 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kaijchen
approved these changes
Jan 12, 2023
|
Thanks @kaijchen |
advancedxy
reviewed
Jan 12, 2023
| @@ -43,6 +43,8 @@ | |||
| public class LocalFileServerReadHandlerTest { | |||
| @Test | |||
| public void testDataInconsistent() throws Exception { | |||
| LocalFileHandlerTestBase.reset(); | |||
There was a problem hiding this comment.
is it necessary to put it under a beforeEach block?
org.apache.uniffle.storage.handler.impl.LocalFileHandlerTest also uses LocalFileHandlerTestBase, is it necessary to modify that class too?
There was a problem hiding this comment.
I think we should refactor LocalFileHandlerTestBase in a later PR.
kaijchen
added a commit
to kaijchen/incubator-uniffle
that referenced
this pull request
Jan 13, 2023
…stDataInconsistent (apache#473)" This reverts commit 7f89d6f.
advancedxy
pushed a commit
that referenced
this pull request
Jan 16, 2023
### What changes were proposed in this pull request? Split `LocalFileHandlerTestBase#writeTestData()` into `generateBlocks()` and `writeTestData()`. Pass `List<Long> blockIds` into `LocalFileHandlerTestBase#calcSegmentBytes()`. ### Why are the changes needed? Followup #473. To make the expected result corresponding to the state of `LocalFileHandlerTestBase#ATOMIC_LONG`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI.
kaijchen
pushed a commit
that referenced
this pull request
Jan 17, 2023
…consistent (#473) ### What changes were proposed in this pull request? 1. Reset the static variable to fix LocalFileServerReadHandlerTest#testDataInconsistent ### Why are the changes needed? Fix flaky test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? 1. Existing UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix flaky test
Does this PR introduce any user-facing change?
No
How was this patch tested?