Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add more logs about data flush #482

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

zuston
Copy link
Member

@zuston zuston commented Jan 13, 2023

What changes were proposed in this pull request?

  1. Exposing more info for DataFlushEvent when logging
  2. Add logs when storage selected is null

Why are the changes needed?

  1. I found sometimes some events are flushed failed but have no related logs, maybe this is caused by the null storage selected. So let's add some logs firstly.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Don't need

@zuston
Copy link
Member Author

zuston commented Jan 13, 2023

Minor improvement. PTAL @advancedxy

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #482 (accfa3a) into master (f4048fc) will decrease coverage by 2.99%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
- Coverage     61.76%   58.77%   -3.00%     
  Complexity     1704     1704              
============================================
  Files           200      206       +6     
  Lines         10305    11468    +1163     
  Branches       1024     1024              
============================================
+ Hits           6365     6740     +375     
- Misses         3589     4317     +728     
- Partials        351      411      +60     
Impacted Files Coverage Δ
...g/apache/uniffle/server/ShuffleDataFlushEvent.java 83.67% <100.00%> (+0.34%) ⬆️
...org/apache/uniffle/server/ShuffleFlushManager.java 84.04% <100.00%> (+0.08%) ⬆️
...oy/kubernetes/operator/pkg/controller/util/util.go 9.37% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 47.70% <0.00%> (ø)
deploy/kubernetes/operator/pkg/webhook/manager.go 53.43% <0.00%> (ø)
...bernetes/operator/pkg/controller/controller/rss.go 32.48% <0.00%> (ø)
...rnetes/operator/pkg/webhook/inspector/inspector.go 69.56% <0.00%> (ø)
...y/kubernetes/operator/pkg/webhook/inspector/pod.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston zuston merged commit 63c1d71 into apache:master Jan 13, 2023
@zuston zuston deleted the logout branch January 13, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants