[ISSUE-484] Fix accidentally remove the storage of appId when unregistering partial shuffle in HdfsStorageManager #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tering partial shuffle in HdfsStorageManager
|
PTAL @jerqi . I think this is an important bug fix. |
zuston
requested review from
duanmeng and
jerqi
and removed request for
duanmeng
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
============================================
- Coverage 58.77% 58.76% -0.02%
- Complexity 1704 1705 +1
============================================
Files 206 206
Lines 11468 11470 +2
Branches 1024 1023 -1
============================================
Hits 6740 6740
- Misses 4317 4319 +2
Partials 411 411
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Jan 13, 2023
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java
Outdated
Show resolved
Hide resolved
|
Looks like there's some flaky test? Overall, this LGTM. |
This flaky test has been recorded in #483. Let's rerun it. |
|
PTAL @advancedxy CI passed. |
advancedxy
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
overall, LGTM.
If @jerqi has time, you can have another look.
|
Merged. Thanks for your review @jerqi @advancedxy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When one app's partial shuffles are removed, it will make other shuffle fail of flushing data due to its missing storage referenced from its appId.
Why are the changes needed?
Fix accidentally remove the storage of appId when unregistering partial shuffle in HdfsStorageManager
Does this PR introduce any user-facing change?
NO
How was this patch tested?