[Improvement] Provides utility classes for creating thread factories #49
Conversation
| @@ -0,0 +1,15 @@ | |||
| package org.apache.uniffle.common.util; | |||
There was a problem hiding this comment.
Could you add license header? Because our project need to follow Apache 2.0 license.
| public static ThreadFactory getThreadFactory(String factoryName) { | ||
| return new ThreadFactoryBuilder().setDaemon(true).setNameFormat(factoryName).build(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you add new line? Otherwise, there will be a format warning.
There was a problem hiding this comment.
Not 31th line. Could you add a new line at the end of file?
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
- Coverage 55.39% 53.97% -1.43%
+ Complexity 1108 1021 -87
============================================
Files 145 137 -8
Lines 7778 7403 -375
Branches 749 719 -30
============================================
- Hits 4309 3996 -313
+ Misses 3230 3180 -50
+ Partials 239 227 -12
Continue to review full report at Codecov.
|
|
LGTM, depend on CI |
|
@smallzhongfeng Could you resolve the conflict? |
smallzhongfeng
force-pushed
the
zjx-thread-factory
branch
from
936f5a6
to
dd5a8e9
Compare
smallzhongfeng
force-pushed
the
zjx-thread-factory
branch
from
dd5a8e9
to
eb3b6ec
Compare
Done ! Could you review it? @jerqi |
What changes were proposed in this pull request?
Provides tool classes for creating thread factories
Why are the changes needed?
Make the code more standardized and beautiful
Does this PR introduce any user-facing change?
No
How was this patch tested?
Use the original test class