Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-489][Minor] Cleanup some code #490

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

iwangjie
Copy link
Contributor

What changes were proposed in this pull request?

We can simplify and standardize some of the code.

Why are the changes needed?

Fixes #489

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing CI.

@iwangjie iwangjie changed the title simplify and standardize some of the code. [ISSUE-489] Simplify and standardize some of the code. Jan 16, 2023
@iwangjie iwangjie mentioned this pull request Jan 16, 2023
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iwangjie for the work.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #490 (43c69c9) into master (654d8c7) will decrease coverage by 0.00%.
The diff coverage is 55.55%.

@@             Coverage Diff              @@
##             master     #490      +/-   ##
============================================
- Coverage     58.77%   58.77%   -0.01%     
+ Complexity     1705     1703       -2     
============================================
  Files           206      206              
  Lines         11469    11464       -5     
  Branches       1023     1021       -2     
============================================
- Hits           6741     6738       -3     
+ Misses         4317     4315       -2     
  Partials        411      411              
Impacted Files Coverage Δ
...pache/hadoop/mapreduce/task/reduce/RssFetcher.java 92.30% <ø> (+1.39%) ⬆️
.../org/apache/uniffle/common/config/ConfigUtils.java 34.44% <0.00%> (ø)
.../java/org/apache/uniffle/server/ShuffleServer.java 64.38% <0.00%> (ø)
.../org/apache/uniffle/server/ShuffleTaskManager.java 76.56% <0.00%> (ø)
...e/uniffle/storage/handler/impl/HdfsFileWriter.java 55.88% <0.00%> (ø)
...g/apache/hadoop/mapred/SortWriteBufferManager.java 79.89% <100.00%> (-0.22%) ⬇️
...ava/org/apache/uniffle/common/util/RetryUtils.java 71.42% <100.00%> (-1.30%) ⬇️
...assignment/PartitionBalanceAssignmentStrategy.java 94.82% <100.00%> (ø)
...e/storage/handler/impl/HdfsShuffleReadHandler.java 56.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen changed the title [ISSUE-489] Simplify and standardize some of the code. [ISSUE-489][Minor] Cleanup some code Jan 16, 2023
@kaijchen kaijchen merged commit 01d37be into apache:master Jan 16, 2023
@kaijchen
Copy link
Contributor

Thanks @iwangjie for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] We can simplify and standardize some of the code
3 participants