Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup UnitConverter and improve UnitConverterTest #504

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Cleanup UnitConverter and improve UnitConverterTest #504

merged 6 commits into from
Jan 19, 2023

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

  1. Remove unused code in UnitConverter.
  2. Make UnitConverter final, and constructor private.
  3. Improve coverage in UnitConverterTest.

Why are the changes needed?

Code quality and test coverage.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing CI.

jerqi
jerqi approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaijchen kaijchen merged commit 47f5c57 into apache:master Jan 19, 2023
@kaijchen kaijchen deleted the test-unit-converter branch January 19, 2023 16:02
@kaijchen
Copy link
Contributor Author

Thanks @jerqi for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaijchen @jerqi