Fixes errors in doc header and operator install command #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
============================================
+ Coverage 58.83% 59.64% +0.80%
- Complexity 1707 1753 +46
============================================
Files 206 205 -1
Lines 11508 11488 -20
Branches 1030 1028 -2
============================================
+ Hits 6771 6852 +81
+ Misses 4323 4232 -91
+ Partials 414 404 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kaijchen
reviewed
Jan 20, 2023
docs/uniffle-migration-guide.md
Outdated
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Why do we need to change this? Looks like other docs also uses this format.
https://github.com/apache/incubator-uniffle/blob/master/docs/server_guide.md?plain=1
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we just move the lisense into comments instead of yaml header?
There was a problem hiding this comment.
Comments? I don't get your point. I have uploaded latest commit and fixed its style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes errors in doc header and operator install command
Why are the changes needed?
Fixes errors in doc header and operator install command
Does this PR introduce any user-facing change?
No
How was this patch tested?
Don't need