Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Switch to slf4j-reload4j #508

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

  1. Replace slf4j-log4j12 with slf4j-reload4j.
  2. Change dependency scope to runtime.

Why are the changes needed?

Eliminate this warning from maven:

[WARNING] While downloading org.slf4j:slf4j-log4j12:1.7.36
  This artifact has been relocated to org.slf4j:slf4j-reload4j:1.7.36.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #508 (9e3eee9) into master (3ba56c5) will increase coverage by 0.75%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #508      +/-   ##
============================================
+ Coverage     59.75%   60.51%   +0.75%     
+ Complexity     1765     1633     -132     
============================================
  Files           205      192      -13     
  Lines         11527    10251    -1276     
  Branches       1033      911     -122     
============================================
- Hits           6888     6203     -685     
+ Misses         4233     3672     -561     
+ Partials        406      376      -30     
Impacted Files Coverage Δ
...preduce/task/reduce/RssRemoteMergeManagerImpl.java
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
...g/apache/hadoop/mapred/SortWriteBufferManager.java
.../hadoop/mapreduce/task/reduce/RssBypassWriter.java
...java/org/apache/hadoop/mapred/SortWriteBuffer.java
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java
...mapreduce/task/reduce/RssInMemoryRemoteMerger.java
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaijchen kaijchen merged commit 33c4fe4 into apache:master Jan 27, 2023
@kaijchen kaijchen deleted the reload4j branch January 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants