[ISSUE-514] Fix flaky test: ShuffleServerGrpcTest#clearResourceTest #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianjingfeng
changed the title
kaijchen
approved these changes
Jan 29, 2023
| @@ -160,7 +160,8 @@ public void clearResourceTest() throws Exception { | |||
|
|
|||
| // clearResourceTest1 will be removed because of rss.server.app.expired.withoutHeartbeat | |||
| t.interrupt(); | |||
| Awaitility.await().timeout(20, TimeUnit.SECONDS).until(() -> shuffleServers.get(0).getShuffleTaskManager().getAppIds().size() == 0); | |||
| Awaitility.await().timeout(20, TimeUnit.SECONDS).until( | |||
| () -> shuffleServers.get(0).getShuffleTaskManager().getAppIds().size() == 0); | |||
| assertEquals(0, shuffleServers.get(0).getShuffleTaskManager().getAppIds().size()); | |||
There was a problem hiding this comment.
This line is not needed now.
However, it's OK to keep it.
advancedxy
approved these changes
Jan 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
============================================
+ Coverage 59.73% 59.75% +0.01%
- Complexity 1764 1765 +1
============================================
Files 205 205
Lines 11527 11527
Branches 1033 1033
============================================
+ Hits 6886 6888 +2
+ Misses 4234 4233 -1
+ Partials 407 406 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test: ShuffleServerGrpcTest#clearResourceTest. Fix #514
Why are the changes needed?
It is flaky test.
In this UT,
rss.server.preAllocation.expired=5000, soShuffleTaskManager#checkResourceStatuswill be invoked for every 2.5 seconds and expired app may will not be removed until 7.5 seconds after stop heartbeat. So sleep 8 seconds may not be reliable.Does this PR introduce any user-facing change?
No
How was this patch tested?
No need